Repository navigation
ci: gate PRs on Nimbus link validation - #34229
Merged
Merged
Conversation
mvvmm
marked this pull request as ready for review
October 12, 2026 17:50
mvvmm
requested review from
a team,
MohamedH1998,
ahaywood and
colbywhite
as code owners
October 12, 2026 17:50
Contributor
AI Review✅ Reviewed Commands
|
Contributor
|
Preview URL: https://943a5ca5.preview.developers.cloudflare.com Files with changes (up to 15)
|
mvvmm
requested review from
a team,
cf-rhett,
csujedihy,
irvinebroque,
ivoryibu,
jiulingz,
joshthoward,
krys-cf,
lambrospetrou,
ngayerie,
ravindra-cloudflare,
rita3ko,
rts-rob,
stechedo,
vy-ton and
zeinjaber
as code owners
October 12, 2026 18:34
diogoascarneiro
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Nimbus 0.17 link validation (
nimbus-docs lint) to CI. It runs in Post Build becausenimbus/internal-linkreads.nimbus/routes.json, which onlyastro buildwrites.CI
.nimbus/as an artifact.::errorannotations (GitHub shows the first 10), writes per-rule counts to the job summary, and fails on any finding, repo-wide.!cancelled()so a lint failure doesn't skip the Workers tests.Config
redirectsFile: "public/__redirects": the Worker reads redirects from this file, so links through them pass.internal-linkignores paths this build doesn't serve:/api/**,/openapi.json,/.well-known/**,**/llms-full.txt,**/og.png.nimbus/redirected-linkset toerror.internal-linkalso ignores**/index.mdand/workers-ai/models/**,/ai/models/**(served or redirected by the Worker).lint:nimbusscript;AGENTS.mdvalidation docs updated.Findings
Link fixes landed in #34232. A local build + lint on this branch reports 0 errors, so the gate starts green.