Skip to content

ci: gate PRs on Nimbus link validation - #34229

Merged
mvvmm merged 2 commits into
productionfrom
ci/nimbus-link-validation
Oct 13, 2026
Merged

mvvmm merged 2 commits into
productionfrom
ci/nimbus-link-validation

Conversation

@mvvmm

@mvvmm mvvmm commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds Nimbus 0.17 link validation (nimbus-docs lint) to CI. It runs in Post Build because nimbus/internal-link reads .nimbus/routes.json, which only astro build writes.

CI

  • Build uploads .nimbus/ as an artifact.
  • Post Build lints. "Check internal links" prints findings grouped by rule, emits ::error annotations (GitHub shows the first 10), writes per-rule counts to the job summary, and fails on any finding, repo-wide.
  • Lint steps use !cancelled() so a lint failure doesn't skip the Workers tests.
  • No secrets or privileged workflows are added.

Config

  • redirectsFile: "public/__redirects": the Worker reads redirects from this file, so links through them pass.
  • internal-link ignores paths this build doesn't serve: /api/**, /openapi.json, /.well-known/**, **/llms-full.txt, **/og.png.
  • nimbus/redirected-link set to error.
  • internal-link also ignores **/index.md and /workers-ai/models/**, /ai/models/** (served or redirected by the Worker).
  • New lint:nimbus script; AGENTS.md validation docs updated.

Findings

Link fixes landed in #34232. A local build + lint on this branch reports 0 errors, so the gate starts green.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://ci-nimbus-link-validation.previews.developers.cloudflare.com (commit 943a5ca)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://86cab69f.previews.developers.cloudflare.com 943a5ca 2026-10-13T14:02:34.945Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://925e8713.previews.developers.cloudflare.com 21ca82e 2026-10-13T01:35:01.462Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://510fae89.previews.developers.cloudflare.com 412200b 2026-10-12T19:46:11.990Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f477f17c.previews.developers.cloudflare.com 569f0a5 2026-10-12T19:23:10.072Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f436a7b3.previews.developers.cloudflare.com e2d2db4 2026-10-12T19:07:03.268Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://e176b0a8.previews.developers.cloudflare.com abc0798 2026-10-12T18:52:35.956Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a7ddf7df.previews.developers.cloudflare.com ccc6c1e 2026-10-12T18:39:48.619Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://639190d4.previews.developers.cloudflare.com ccb58a7 2026-10-12T18:10:44.728Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://aa8c8d57.previews.developers.cloudflare.com ad6db0c 2026-10-12T17:52:18.712Z Visit the dashboard ↗

@mvvmm
mvvmm marked this pull request as ready for review October 12, 2026 17:50
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

AI Review

✅ Reviewed 943a5ca · 0 findings · incremental

Commands
  • /review Run a review now.
  • /full-review Review the entire PR diff.
  • /disable-auto-review Stop automatic reviews.
  • /rebase Rebase against production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants