Skip to content

add xlsx export suppport to workspace-sheets blueprint - #433

Merged
maxwellpeterson merged 10 commits into
mainfrom
mpeterson/xlsx-export
Sep 8, 2026
Merged

add xlsx export suppport to workspace-sheets blueprint#433
maxwellpeterson merged 10 commits into
mainfrom
mpeterson/xlsx-export

Conversation

@maxwellpeterson

@maxwellpeterson maxwellpeterson commented Sep 3, 2026

Copy link
Copy Markdown
Member

update built-in sheets blueprint to support xlsx export

@github-actions github-actions Bot added the kernel Changes to the Workshop kernel label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Preview: pr433-mpeterson-xlsx-export

https://pr433-mpeterson-xlsx-export-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

Findings

  • Medium xlsx.js:361: Cells outside declared rows/cols are silently omitted, although the server accepts and persists them and CSV exports them. Export all valid Excel references or reject/prune them when stored.
  • Medium xlsx.js:463: nf: "text" converts formulas to literal strings. The app evaluates formulas independently of number formatting, so XLSX export changes workbook behavior.
  • Medium xlsx.js:385: Each unmatched apostrophe rescans the remaining formula, producing quadratic work. Valid 8,192-character cells can exceed the 30-second export deadline with only a few hundred formulas. Parse quoted references in one pass.

github run

@maxwellpeterson
maxwellpeterson marked this pull request as ready for review September 3, 2026 03:11
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

@maxwellpeterson Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

Submitted one review with 3 actionable inline findings.

github run

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

Submitted one review with 3 actionable inline findings.

github run

devin-ai-integration[bot]

This comment was marked as resolved.

ask-bonk[bot]

This comment was marked as resolved.

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

Submitted one review with 2 actionable inline findings. Focused XLSX tests pass (24/24).

github run

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

Submitted one review with 3 actionable inline findings.

github run

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 3, 2026

Copy link
Copy Markdown

Submitted 1 inline finding. Additional findings:

  • High server.js:102: Delayed broadcasts can overwrite a sender’s newer local state, while its own corrective event is ignored.
  • Medium xlsx.js:549: =2^3^2 changes from 512 locally to 64 in Excel due to associativity differences.
  • Medium xlsx.js:252: Font sizes are stored/rendered as pixels but exported as points, making custom fonts about 33% larger.

github run

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

devin-ai-integration[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 4, 2026

Copy link
Copy Markdown

Findings

  • Medium xlsx.js:531: Malformed formulas accepted by the grid, such as =SUM(1,2 or ="abc, are emitted as invalid Excel formulas. Validate them or export as text.
  • Medium xlsx.js:531: Out-of-grid references remain formulas despite their cells being omitted. For example, =XFE1+1 evaluates locally but becomes #NAME? in Excel.

Focused tests pass (23/23).

github run

@ask-bonk

ask-bonk Bot commented Sep 4, 2026

Copy link
Copy Markdown

Findings

  • Medium xlsx.js:456: Names requiring Excel delimiters, such as R1C1 or $Data, remain unquoted, breaking cross-sheet formulas. Quote unchanged names when required.
  • Medium xlsx.js:311: Date serial 1 displays 12/31/1899 locally but 01/01/1900 in Excel due to incompatible epochs.
  • Medium xlsx.js:303: Integer formatting changes -1.5 from -1 locally to -2 in Excel because rounding semantics differ.

github run

devin-ai-integration[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 8, 2026

Copy link
Copy Markdown

APIError: You do not have access to the organization tied to the API key.

github run

2 similar comments
@ask-bonk

ask-bonk Bot commented Sep 8, 2026

Copy link
Copy Markdown

APIError: You do not have access to the organization tied to the API key.

github run

@ask-bonk

ask-bonk Bot commented Sep 8, 2026

Copy link
Copy Markdown

APIError: You do not have access to the organization tied to the API key.

github run

@maxwellpeterson
maxwellpeterson merged commit 81f6a0e into main Sep 8, 2026
15 of 16 checks passed
@maxwellpeterson
maxwellpeterson deleted the mpeterson/xlsx-export branch September 8, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Changes to the Workshop kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants