Extract sentry hook into separate foundations-sentry crate#203
Merged
Conversation
TheJokr
force-pushed
the
lblocher/sentry-upgrade
branch
2 times, most recently
from
7df7e59 to
18f077d
Compare
fisherdarling
approved these changes
Apr 28, 2026
TheJokr
force-pushed
the
lblocher/sentry-upgrade
branch
from
18f077d to
069d8ae
Compare
Sentry's Rust client regularly publishes new major versions. They are on version `0.47` now. Any `sentry` upgrade requires a `foundations` major release as well, because we depend on sentry's public API. By extracting the `sentry` feature from `foundations`, we can limit these major releases to the new crate. The new crate will use the latest sentry version from the start. We keep the old code around for compatibility, but mark it as deprecated. It will be removed in the next major release. There are some alternatives: - Allowing multiple major versions in our `Cargo.toml`. This is annoying because Cargo defaults to the latest version, causing duplicate dependencies and version mismatch errors. - Having separate features per `sentry` major release. This would mean we need to maintain (or at least keep around) multiple versions of the same code, when really we just want people to upgrade to the latest sentry release.
TheJokr
force-pushed
the
lblocher/sentry-upgrade
branch
from
069d8ae to
8e82378
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry's Rust client regularly publishes new major versions. They are on
version
0.47now. Anysentryupgrade requires afoundationsmajorrelease as well, because we depend on sentry's public API. By extracting
the
sentryfeature fromfoundations, we can limit these majorreleases to the new crate.
The new crate will use the latest sentry version from the start. We keep
the old code around for compatibility, but mark it as deprecated. It
will be removed in the next major release.
There are some alternatives:
Cargo.toml. This is annoyingbecause Cargo defaults to the latest version, causing duplicate
dependencies and version mismatch errors.
sentrymajor release. This would meanwe need to maintain (or at least keep around) multiple versions of the
same code, when really we just want people to upgrade to the latest
sentry release.
Includes setup for releasing
foundations-sentryseparately from the maincrate and a release commit for
foundations-sentry 1.0.0.