Skip to content

Arunc/dialog cleanup#448

Open
arunc wants to merge 4 commits intocloudflare:mainfrom
arunc:arunc/dialog-cleanup
Open

Arunc/dialog cleanup#448
arunc wants to merge 4 commits intocloudflare:mainfrom
arunc:arunc/dialog-cleanup

Conversation

@arunc
Copy link
Copy Markdown

@arunc arunc commented Apr 24, 2026

fix(dialog): clarify alertdialog usage and fix demo inconsistencies
Improves the Dialog component documentation and demo examples to better
communicate the distinction between dialog and alertdialog roles.

Changes:

  • dialog.tsx: Added JSDoc note to Dialog.Root role prop clarifying
    that alertdialog should not include a header close button — users must
    respond via explicit action buttons in the footer
  • DialogDemo.tsx: Updated DialogWithActionsDemo to use a non-destructive
    "Save changes" flow (previously used "Delete"), reserving destructive
    actions for alertdialog demos only
  • DialogDemo.tsx: Added role="alertdialog" to DialogConfirmationDemo
    for correct accessibility semantics
  • DialogDemo.tsx: Wrapped "Create" primary buttons in Dialog.Close in
    DialogWithSelectDemo and DialogWithComboboxDemo so they close the dialog
  • dialog.mdx: Added missing description to "With Actions" example section

  • Reviews
    • bonk has reviewed the change
    • [x ] automated review not possible because: documentation and demo-only changes
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: no functional code changes

arunc added 3 commits April 27, 2026 10:07
- Change close buttons from secondary to ghost variant for consistency
- Update "With Actions" demo to show save workflow instead of delete
- Add alertdialog role to confirmation demo and update description to explain disablePointerDismissal behavior
- Wrap primary action buttons in Dialog.Close for proper dismissal
- Add JSDoc note about excluding header close button from alertdialog role
- Add descriptive text to "With Actions" example section
@arunc arunc force-pushed the arunc/dialog-cleanup branch from f7f9e66 to a3651ce Compare April 27, 2026 15:09
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 27, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@448

commit: a3651ce

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: a3651ce

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Report — 24 changed, 13 unchanged

24 screenshot(s) with visual changes:

Button / Basic

90 px (0.09%) changed

Before After Diff
Before After Diff

Button / Variant: Primary

166 px (0.16%) changed

Before After Diff
Before After Diff

Button / Variant: Destructive

585 px (0.58%) changed

Before After Diff
Before After Diff

Button / With Icon

272 px (0.27%) changed

Before After Diff
Before After Diff

Button / Loading State

870 px (0.86%) changed

Before After Diff
Before After Diff

Button / Title

272 px (0.27%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

394 px (0.39%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

192 px (0.19%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

862 px (0.85%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

352 px (0.35%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

244 px (0.24%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

130 px (0.13%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

130 px (0.13%) changed

Before After Diff
Before After Diff

Dialog (Open)

542,176 px (2.64%) changed

Before After Diff
Before After Diff

Select / Select Basic

530 px (0.52%) changed

Before After Diff
Before After Diff

Select / Select Sizes

901 px (0.48%) changed

Before After Diff
Before After Diff

Select / Select Without Label

183 px (0.18%) changed

Before After Diff
Before After Diff

Select / Select With Field

635 px (0.54%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

418 px (0.41%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

294 px (0.29%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Disabled Options

765 px (0.75%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

450 px (0.44%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
13 screenshot(s) unchanged
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / Icon Only
  • Button / Disabled State
  • Select / Select Custom Rendering
  • Select / Select Multiple
  • Select / Select Complex
  • Select / Select Disabled Items
  • Select / Select Grouped
  • Select / Select Long List

Generated by Kumo Visual Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant