fix(collapsible): forward all Panel props through DefaultPanel#468
Merged
mattrothenberg merged 2 commits intomainfrom May 1, 2026
Merged
fix(collapsible): forward all Panel props through DefaultPanel#468mattrothenberg merged 2 commits intomainfrom
mattrothenberg merged 2 commits intomainfrom
Conversation
DefaultPanel's type was a standalone interface with only children and className, silently dropping props like keepMounted. Extend BasePanelProps and spread remaining props so DefaultPanel accepts everything Panel does.
Collaborator
Author
|
/bonk please approve |
Contributor
There was a problem hiding this comment.
/bonk approved
Clean mechanical fix that properly forwards Base UI Panel props through Collapsible.DefaultPanel. The interface now extends BasePanelProps and spreads remaining props to the underlying component, bringing it to parity with Collapsible.Panel.
- Code follows existing patterns ✅
- keepMounted demo added ✅
- API docs updated ✅
- Changeset included ✅
Contributor
|
Approved PR #468. The fix correctly extends |
commit: |
Contributor
Docs PreviewCommit: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



















































Summary
Collapsible.DefaultPanelhad a standalone props interface (children+classNameonly), silently dropping props likekeepMountedandhiddenUntilFoundthatCollapsible.PanelsupportsExtended
CollapsibleDefaultPanelPropsfromBasePanelPropsand spread remaining props through to the underlying Base UIPanel, bringing it to parity withCollapsible.PanelAdded a
keepMounteddemo to the docs showing state preservation across collapse/expandUpdated the DefaultPanel API reference table
Reviews
bonk has reviewed the change
automated review not possible because: straightforward prop forwarding fix
Tests
Tests included/updated
Additional testing not necessary because: typecheck passes, no existing component tests to update, and the change is a mechanical props passthrough