Fix load balancer shutdown responsiveness#884
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #878
LoadBalancer::runnow races shutdown notifications against service discovery updates, health checks, and interval sleeps. That lets the background task return promptly when shutdown arrives instead of waiting for the next loop iteration or a pending update/probe.For parallel health checks, spawned probe tasks now get abort handles tied to the waiting future, so cancellation does not leave detached pending probe tasks behind.
Tests:
cargo test -p pingora-load-balancing background::tests -- --nocapturecargo fmt --all -- --checkcargo clippy -p pingora-load-balancing --all-targets -- -D warningscargo check -p pingora-load-balancingLocal note:
cargo test -p pingora-load-balancing --no-fail-fastcurrently fails inhealth_check::test_http_custom_checkbecausehttp://one.one.one.one/returns302in this environment while the existing test expects301; the new shutdown tests pass.