Make ring an optional dependency in pingora-rustls#887
Open
mattgarmon wants to merge 1 commit into
Open
Conversation
592d130 to
7687fae
Compare
|
Hi Matt, The approach is more like I see in other crates and also pingora, only a generic rustls feature. Than user choose, in this case, 2 options: ring or aws lc rs. Here is how I am using Than I have no ring in my tree and all use fips. The only changed from #630 is All other crates can keep the rustls feature as it is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
ringoptional inpingora-rustlsAlternative to #630.
Summary
pingora-rustlsunconditionally depends onringand activatesrustls/ring, which prevents consumers from using a differentCryptoProvider(e.g.aws-lc-rsfor FIPS builds).This PR makes
ringan optional, default-on feature and adds arustls-no-ringfeature across the crate stack. No new dependencies. Fully backward compatible, andrustlscontinues to includering.This follows the approach suggested by @53v3n3d4 in #630, extended across the full crate stack so consumers can use it without patching
pingora-core.Consumers who bring their own provider: