Enable default children on gateway destination#39
Open
wieseljonas wants to merge 2 commits intocloudflare:masterfrom
Open
Enable default children on gateway destination#39wieseljonas wants to merge 2 commits intocloudflare:masterfrom
wieseljonas wants to merge 2 commits intocloudflare:masterfrom
Conversation
|
For the mean time, if anybody's interested, I made a component that allows this instead. import * as React from 'react'
import { GatewayDest } from 'react-gateway'
function GatewayDestWithFallback(props) {
return (
<GatewayDest name={props.name} component={Inner} fallback={props.fallback}>
{props.children}
</GatewayDest>
)
}
function Inner(props) {
return props.children || props.fallback || <div />
}
export default GatewayDestWithFallbackUsage <GatewayDestWithFallback name="my-top-nav-title" fallback={<Logo />} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very useful for me as I use
Gatewayfor my navigation and it enables me to change navigation items from every every route or have the default value displayes