fix(ruleset): convert action_parameters.rules map values from strings to lists#277
Merged
tamas-jozsa merged 2 commits intomainfrom Apr 16, 2026
Merged
fix(ruleset): convert action_parameters.rules map values from strings to lists#277tamas-jozsa merged 2 commits intomainfrom
tamas-jozsa merged 2 commits intomainfrom
Conversation
… to lists In v4, action_parameters.rules in skip/execute rules was map(string) where values were single or comma-separated rule IDs. In v5, this changed to map(list(string)) where every value must be an explicit list. The migrator was not handling this conversion, causing terraform plan to fail with 'list of string required' after migration.
…n up redundant rules Add exemptions for three new drift patterns found in api-team-production: - terminates = false -> null (LB rules, via new global bool-to-null patterns) - notification_filter empty removal (LB pool, new in v5 provider) - value int-to-string coercion (zone setting, v5 DynamicAttribute) Clean up existing exemptions: - Add global '= false -> null' / '= true -> null' patterns for optional bool state upgrader gaps - Remove load_balancer.yaml (covered by global) - Remove redundant computed_only_fields (zero_trust_dlp_predefined_profile) - Remove redundant status_pending_to_null, tighten patterns (zone_dnssec) - Remove dead session_duration_normalization (zero_trust_access_policy) - Remove test-data-specific patterns from origins_reorder_drift (LB pool) - Fix verbose_exemptions debug leftover (zero_trust_local_fallback_domain)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v4, action_parameters.rules in skip/execute rules was map(string) where
values were single or comma-separated rule IDs. In v5, this changed to
map(list(string)) where every value must be an explicit list.
The migrator was not handling this conversion, causing terraform plan to fail
with 'list of string required' after migration.