Skip to content

No support for ECDSA P-256 #71

Description

@SegalMan

I'd like to open a PR supporting ECDSA P-256 at least for verification as that is my current need (already using the library with an ed25519 and now having to add a key using this algorithm)

The only main decisions I see from my perspective in that regard:

  1. Which create should be used (leading candidates are p256 and ecdsa)?
  2. The FailedToVerify error currently having an associated ed25519_dalek::SignatureError, meaning I'd need to either introduce a separate error for verification failure for ECDSA or introduce breaking changes to that error

I didn't want to overstep and directly open a PR, so let's discuss :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions