chore: Fix testlib so that failing tests are reported as failing - #260
Merged
hoodmane merged 1 commit intoSep 16, 2026
Merged
Conversation
dom96
approved these changes
Sep 15, 2026
Contributor
|
Huh, so we were silently ignoring failing tests? |
pytest_runtest_makereport is called with status="passed", when="teardown" when teardown succeeds even when the test failed. We were previously overwriting the fail info with the teardown.
hoodmane
force-pushed
the
hoodmane/dont-pass-failing-tests
branch
from
September 16, 2026 21:43
3fe996d to
7626900
Compare
Contributor
Author
|
Indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest_runtest_makereport is called with status="passed", when="teardown" when teardown succeeds even when the test failed. We were previously overwriting the fail info with the teardown.