Skip to content

chore: Clean up remaining django-cf lints #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoodmane merged 1 commit into from
Sep 16, 2026
+2 −9
Merged

chore: Clean up remaining django-cf lints #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/django-cf/django_cf/db/backends/do/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


def set_storage(db):
global storage
global storage # noqa: PLW0603
storage = db


Expand Down
8 changes: 0 additions & 8 deletions packages/django-cf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@ exclude = ["tests*", "docs*", "templates*", ".github*", "*.__pycache__"]
extend = "../../ruff.toml"
target-version = "py312"
extend-exclude = [".wrangler", "python_modules", "staticfiles"]
lint.extend-ignore = [
# Deferred: satisfying these requires behavioural or structural changes to
# code imported from https://github.com/G4brym/django-cf, so they are turned
# off to keep the lint adoption commit mechanical. Re-enable one rule per PR.
"PLR0913", # too many arguments; signature change
"PLR2004", # magic value comparison; needs named constants
"PLW0603", # global statement; architectural, see db/backends/do/storage.py
]
# Generated Django scaffolding kept verbatim so it stays copy-pasteable.
lint.per-file-ignores."tests/servers/**" = ["F401"]
lint.per-file-ignores."templates/**" = ["F401"]
Expand Down
1 change: 1 addition & 0 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ ignore = [
"C901", # Too complex
"E501", # Line too long
"PLR0911", # Too many return statements
"PLR0913", # Too many arguments
"PLR0915", # Too many statements
"PLR2004", # Magic value
"PLW2901", # loop variable overwritten by assignment
Expand Down
Loading