fix(runtime-sdk): Make NonRetryableError raised in a workflow step non-retryable - #266
Merged
hoodmane merged 2 commits intoSep 18, 2026
Merged
Conversation
ryanking13
approved these changes
Sep 18, 2026
ryanking13
left a comment
ryanking13
left a comment
Contributor
There was a problem hiding this comment.
I left some comments but it looks good overall
hoodmane
force-pushed
the
hoodmane/workflow-nonretryable
branch
2 times, most recently
from
September 18, 2026 20:37
a7e2715 to
5c68efa
Compare
…ith the SDK wrangler registers `.js`/`.mjs` files under `python_modules/workers/` as ES modules, so JavaScript can ship inside the `workers` package and be loaded at runtime.
…n-retryable The Workflows engine decides whether to retry a failed step from the JS error's name. A Python exception reaches it as a Pyodide PythonError whose message is the traceback, so `workers.workflows.NonRetryableError` was silently retried like any other error. This adds a new workflows.js shim that fixes the translation of NonRetryableError to JavaScript so this works correctly.
hoodmane
force-pushed
the
hoodmane/workflow-nonretryable
branch
from
September 18, 2026 20:45
5c68efa to
2ccc864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Workflows engine decides whether to retry a failed step from the JS error's
name. A Python exception reaches it as a Pyodide PythonError whose message is the
traceback, so
workers.workflows.NonRetryableErrorwas silently retried like anyother error. This adds a new workflows.js shim that fixes the translation of
NonRetryableError to JavaScript so this works