refactor(miniflare): centralize internal paths and move platform proxy endpoint#12686
Open
edmundhung wants to merge 5 commits intomainfrom
Open
refactor(miniflare): centralize internal paths and move platform proxy endpoint#12686edmundhung wants to merge 5 commits intomainfrom
edmundhung wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: db29394 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude encountered an error —— View job Changeset Review
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
edmundhung
force-pushed
the
edmundhung/refactor-platform-proxy-api
branch
from
9dd796d to
88422f3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
edmundhung
force-pushed
the
edmundhung/refactor-platform-proxy-api
branch
2 times, most recently
from
c54485a to
dcd3868
Compare
Contributor
|
✅ All changesets look good |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
edmundhung
force-pushed
the
edmundhung/refactor-platform-proxy-api
branch
from
9f2df6b to
dc11845
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
edmundhung
force-pushed
the
edmundhung/refactor-platform-proxy-api
branch
from
5c3c95a to
db29394
Compare
edmundhung
commented
Mar 4, 2026
| const request = new Request(this.bridge.url, userRequest); | ||
| // If adding new headers here, remember to `delete()` them in `ProxyServer` | ||
| // before calling `fetch()`. | ||
| request.headers.set(CoreHeaders.OP_ORIGINAL_URL, userRequest.url); |
Member
Author
There was a problem hiding this comment.
This preserves the caller's original fetch URL because request.url is now rewritten to /cdn-cgi/platform-proxy before proxy dispatch.
edmundhung
commented
Mar 4, 2026
| try { | ||
| if (dispatcherUrl !== url) { | ||
| dispatcherUrl = url; | ||
| dispatcher = new Pool(new URL(url).origin, { |
Member
Author
There was a problem hiding this comment.
undici Pool expects a request origin instead of full URL: https://undici.nodejs.org/#/docs/api/Pool?id=class-pool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes n/a.
This is just an internal refactor to centralize all our
/cdn-cgipaths. No behavior changes.A picture of a cute animal (not mandatory, but encouraged)