[wrangler] Add `wrangler flagship` commands by akshitsinha · Pull Request #14423 · cloudflare/workers-sdk

akshitsinha · 2026-06-25T09:30:49Z

Adds wrangler flagship for managing Cloudflare Flagship apps and feature flags.

This includes apps commands for create/list/get/update/delete, and flags commands for create/list/get/update/set/split/rollout/enable/disable/evaluate/delete/changelog, with aliases, --json output, config binding fallback for app IDs, human-readable rendering, and unit test coverage.

Includes a wrangler minor changeset.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s): Add wrangler flagship command documentation cloudflare-docs#31825
- Documentation not necessary because: Flagship Wrangler command docs will be added in a separate cloudflare-docs PR after this lands.

changeset-bot · 2026-06-25T09:30:56Z

🦋 Changeset detected

Latest commit: a556313

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Minor
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-06-25T09:31:16Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

.changeset/flagship-cli-commands.md: [@cloudflare/wrangler]
packages/wrangler/src/tests/flagship.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/tests/index.test.ts: [@cloudflare/wrangler]
packages/wrangler/src/core/teams.d.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/apps/create.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/apps/delete.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/apps/get.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/apps/list.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/apps/update.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/client.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/changelog.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/create.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/delete.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/enable.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/evaluate.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/get.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/list.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/rollout.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/set.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/split.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/flags/update.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/index.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/render.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/resolve.ts: [@cloudflare/wrangler]
packages/wrangler/src/flagship/shared.ts: [@cloudflare/wrangler]
packages/wrangler/src/index.ts: [@cloudflare/wrangler]

pkg-pr-new · 2026-06-25T09:36:34Z

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14423

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14423

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14423

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14423

miniflare

npm i https://pkg.pr.new/miniflare@14423

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14423

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14423

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14423

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14423

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14423

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14423

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14423

wrangler

npm i https://pkg.pr.new/wrangler@14423

commit: a556313

Add `wrangler flagship` commands for managing Flagship apps and feature flags. The new `wrangler flagship apps` and `wrangler flagship flags` command groups let you create, list, get, inspect, update, set, split, rollout, enable, disable, evaluate, and delete Flagship apps and flags from the CLI, including targeting rules, variations, percentage rollouts, evaluation context, and flag changelogs.

workers-devprod · 2026-07-01T13:22:29Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

devin-ai-integration

Devin Review found 1 new potential issue.

devin-ai-integration · 2026-07-01T19:35:59Z

+export async function listApps(config: Config): Promise<App[]> {
+	const accountId = await requireAuth(config);
+	return await fetchResult(config, `/accounts/${accountId}/flagship/apps`, {
+		method: "GET",
+	});
+}


🚩 Apps listing does not support pagination unlike flags listing

The listApps function at packages/wrangler/src/flagship/client.ts:151-156 uses a simple fetchResult call that returns all apps in a single response. In contrast, listFlags (client.ts:192-205) uses fetchPage with cursor-based pagination, and the CLI exposes --limit, --cursor, and --all options. If the number of apps grows large enough to be paginated by the API, listApps would only return the first page. This may be intentional if the API doesn't paginate apps, but it's an asymmetry worth noting.

Was this helpful? React with 👍 or 👎 to provide feedback.

petebacondarwin

Left a small number of nits but looks good.
Can you get a member of your product team to either actually approve the PR or comment with their approval that this all does what it is expected of the product?

petebacondarwin · 2026-07-01T14:55:54Z

+	}
+	const byPriority = new Map(rules.map((rule) => [rule.priority, rule]));
+	const existing = sortedRules(rules).map((rule) => rule.priority);
+	if (order.length !== rules.length || new Set(order).size !== order.length) {


NIT: you could probably just do:

Suggested change

if (order.length !== rules.length || new Set(order).size !== order.length) {

if (new Set(order).size !== rules.length) {

petebacondarwin · 2026-07-01T19:58:49Z

+		target: {
+			type: "string",
+			array: true,
+			demandOption: true,
+			description: "The app ID followed by one or more flag keys to delete",
+		},


Why does this command not take the app-id as its own positional parameter?

petebacondarwin · 2026-07-01T19:59:36Z

+			target: {
+				type: "string",
+				array: true,
+				demandOption: true,
+				description: `The app ID followed by one or more flag keys to ${verb.toLowerCase()}`,
+			},


Similarly, why does target conflate app-id and keys?

petebacondarwin · 2026-07-01T20:06:48Z

+import type { FlagType, Rule } from "../client";
+
+export const flagshipFlagsUpdateCommand = createCommand({
+	metadata: {


This feels like a command that could really do with some examples.

petebacondarwin · 2026-07-01T20:08:31Z

+import { UserError } from "@cloudflare/workers-utils";
+import { logger } from "../logger";
+
+export function splitAppIdAndKeys(targets: string[]): {


why export this one?

petebacondarwin · 2026-07-01T20:16:35Z

+	if (typeof value === "string") {
+		return `"${value}"`;
+	}
+	return JSON.stringify(value) ?? String(value);


stringify() will always return a string or undefined so I assume what you want here is that if value is undefined we get the string "undefined"?

petebacondarwin · 2026-07-01T20:18:12Z

+	if (typeof value === "string") {
+		return `"${value}"`;
+	}


This is not necessary since if value is a string then JSON.stringify(value) will return exactly what is being generated here.

workers-devprod

Codeowners reviews satisfied

akshitsinha requested a review from workers-devprod as a code owner June 25, 2026 09:30

workers-devprod added this to workers-sdk Jun 25, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jun 25, 2026

workers-devprod requested review from a team and emily-shen and removed request for a team June 25, 2026 09:31

akshitsinha force-pushed the asinha/flagship branch from 985b941 to e0b3fb6 Compare June 25, 2026 09:33

This comment was marked as resolved.

Sign in to view

akshitsinha marked this pull request as draft June 25, 2026 10:17

This comment was marked as resolved.

Sign in to view

akshitsinha force-pushed the asinha/flagship branch from 2c729ff to e0b6e06 Compare July 1, 2026 08:21

akshitsinha force-pushed the asinha/flagship branch from e0b6e06 to 311aa58 Compare July 1, 2026 08:26

akshitsinha marked this pull request as ready for review July 1, 2026 13:22

This comment was marked as resolved.

Sign in to view

petebacondarwin requested review from petebacondarwin and removed request for emily-shen July 1, 2026 13:43

fix: throw JsonFriendlyFatalError

97b6976

This comment was marked as resolved.

Sign in to view

fix: renumber flagship rules after deletion

a556313

devin-ai-integration Bot reviewed Jul 1, 2026

View reviewed changes

petebacondarwin approved these changes Jul 1, 2026

View reviewed changes

workers-devprod approved these changes Jul 1, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jul 1, 2026

	if (order.length !== rules.length \|\| new Set(order).size !== order.length) {
	if (new Set(order).size !== rules.length) {

Uh oh!

Conversation

akshitsinha commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

workers-devprod commented Jun 25, 2026

Uh oh!

pkg-pr-new Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

workers-devprod commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akshitsinha commented Jun 25, 2026 •

edited

Loading

changeset-bot Bot commented Jun 25, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 25, 2026 •

edited

Loading

workers-devprod commented Jul 1, 2026 •

edited

Loading