Make droplet's lifecycle information available #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujc25
reviewed
Dec 10, 2025
resources/droplet_resource.go
Outdated
| // An object describing the lifecycle that was used when staging the droplet | ||
| // possible values for type: "buildpack", "cnd", "docker" | ||
| type DropletLifecycle struct { | ||
| Type string `json:"name"` |
Contributor
There was a problem hiding this comment.
Should we call the json tag as type instead of name here? That is how the cloud-controller api returns the response as well.
resources/droplet_resource.go
Outdated
| } | ||
|
|
||
| // An object describing the lifecycle that was used when staging the droplet | ||
| // possible values for type: "buildpack", "cnd", "docker" |
Contributor
There was a problem hiding this comment.
Suggested change
| // possible values for type: "buildpack", "cnd", "docker" | |
| // possible values for type: "buildpack", "cnb", "docker" |
benjaminguttmann-avtq
force-pushed
the
add-droplet-lifecycle-information-v8
branch
from
92140fa to
297ece9
Compare
benjaminguttmann-avtq
deleted the
add-droplet-lifecycle-information-v8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The PR makes the droplet's lifecycle information available as a property of the droplet object.
Why Is This PR Valuable?
Within cf_exporter we want to specify different actions based on which droplet lifecycle is used. Therefore we need to make that information available.
Applicable Issues
How Urgent Is The Change?
not urgent
Other Relevant Parties
Who else is affected by the change?