[v8][cherry-pick] Fix(ci): correct label gate condition to use event.action instead of event_name#3810
Open
prkalle wants to merge 1 commit into
Open
[v8][cherry-pick] Fix(ci): correct label gate condition to use event.action instead of event_name#3810prkalle wants to merge 1 commit into
prkalle wants to merge 1 commit into
Conversation
prkalle
force-pushed
the
fix/ci_getsha_skip_v8
branch
from
a8abad1 to
9d6d0d1
Compare
…event_name github.event_name is always 'pull_request_target' for all PR trigger types. The action type (labeled, synchronize, etc.) is exposed via github.event.action, so the safe-to-test label check was never evaluating to true Signed-off-by: Prem Kumar Kalle <prem.kalle@broadcom.com>
prkalle
force-pushed
the
fix/ci_getsha_skip_v8
branch
from
9d6d0d1 to
1309689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is cherry-pick of #3809
This PR fixes the label gate condition to use github.event.action instead of github.event_name.
Why Is This PR Valuable?
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Fairly urgent to fix CI
Other Relevant Parties
Who else is affected by the change?