Skip to content

Handle multiple bindings between app and service #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theghost5800 wants to merge 2 commits into
base: master
Choose a base branch
from

Fix comments

7a54f1e
Select commit
Loading
Failed to load commit list.
Open

Handle multiple bindings between app and service #1820

Fix comments
7a54f1e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 28, 2026 in 1m 20s

Quality Gate failed

Failed conditions
68.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 144 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/steps/DetermineApplicationServiceBindingActionsStepTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "buildExistingBinding" method. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ2-q4MuDYuIHC9AFWul&open=AZ2-q4MuDYuIHC9AFWul&pullRequest=1820

Check warning on line 161 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/steps/PollServiceUnbindingsOperationExecutionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ3UaF6J4KFe9K3-kRU_&open=AZ3UaF6J4KFe9K3-kRU_&pullRequest=1820

Check warning on line 1741 in multiapps-controller-client/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this type parametrization by the 'final' type `ServiceBindingResource`. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ20z1Qo9hZDB1hNc9K6&open=AZ20z1Qo9hZDB1hNc9K6&pullRequest=1820

Check warning on line 65 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/UnbindServiceFromApplicationStep.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ20z1O99hZDB1hNc9K5&open=AZ20z1O99hZDB1hNc9K5&pullRequest=1820
View more details on SonarQubeCloud