Skip to content

Add the ability to use TLS to the redis-session extension#1182

Merged
ramonskie merged 3 commits intocloudfoundry:masterfrom
atgitwk:master
Feb 25, 2026
Merged

Add the ability to use TLS to the redis-session extension#1182
ramonskie merged 3 commits intocloudfoundry:masterfrom
atgitwk:master

Conversation

@atgitwk
Copy link
Contributor

@atgitwk atgitwk commented Jul 13, 2025

Hello,
PHP buildpack does not seem to support the automatic setting of php ini session_save_path variable for redis-sessions services with TLS.
extensions/sessions/extension.py only handles the 'tcp:' scheme.

    def session_save_path(self):
        return "tcp://%s:%s?auth=%s" % (
            self.creds.get('hostname',
                           self.creds.get('host', 'not-found')),
            self.creds.get('port', 'not-found'),
            self.creds.get('password', ''))

To use TLS, the Redis 'uri' specification indicates that the ‘uri’ parameter could be set with scheme ‘rediss://’ instead of ‘redis://’.
This 'uri' parameter could be initialized in the json binding credentials configuration provided by the service broker.
Here's a proposal PR for managing redis-session with TLS

  • I have viewed signed and have submitted the Contributor License Agreement
    Go an error at link Individual CLA : Error 404 Not Found 😟

  • I have made this pull request to the master branch

  • I have added an integration test

@atgitwk atgitwk requested a review from a team July 13, 2025 22:08
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@atgitwk
Copy link
Contributor Author

atgitwk commented Aug 23, 2025

Hi team
My PR is still in pending review but cloudfoundry/wg-app-runtime-interfaces-buildpacks-php-approvers returns HTTP 404 "Page not found" 😞
Is this normal ?
May anyone help ?

@ramonskie
Copy link
Contributor

hi sorry for the delay. allot of happend in the past few months.

i would kindly ask if you could create a new pr for the new buildpack. as this is now rewriten in go
and as soon as i see your new pr we will review and merge it
let me know if you need any more information

@atgitwk
Copy link
Contributor Author

atgitwk commented Feb 18, 2026

Hi @ramonskie
I have updated my forked version with the major version 5.x.x and added the proposed solution but in Go now.
Is it ok ?

@atgitwk
Copy link
Contributor Author

atgitwk commented Feb 25, 2026

Thanks, @ramonskie.
It may be implemented in the next release ? Any date ?

@ramonskie ramonskie merged commit e8aeb7d into cloudfoundry:master Feb 25, 2026
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants