Update fixture composer.lock files for PHP 8.3 compatibility#1234
Merged
Update fixture composer.lock files for PHP 8.3 compatibility#1234
Conversation
The laminas and cake fixture composer.lock files had stale package constraints that only supported up to PHP 8.2. The buildpack selects PHP 8.3 by default, causing integration tests to fail with dependency resolution errors. - laminas: laminas-mvc 3.3.x -> 3.8.0, laminas-component-installer 3.2.0 -> 3.7.0 - cake: cakephp/cakephp 4.4.8 -> 4.4.18 (plus transitive dep updates) Regenerated both lock files using PHP 8.3 + Composer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
laminasandcakeintegration test fixtures had stalecomposer.lockfiles whose locked package versions only supported PHP ≤8.2. The buildpack selects PHP 8.3 by default, causing integration tests to fail at thecomposer installstage.This is a pre-existing bug introduced when
composer.jsonwas updated to allow PHP 8.3 (commit784d55510) but the lock files were never regenerated.Changes
Both lock files were regenerated using
php:8.3-cli+ Composer, with--no-scripts --no-plugins:laminaslaminas/laminas-mvclaminaslaminas/laminas-component-installercakecakephp/cakephpcakeTesting
AppFrameworks/LaminasandAppFrameworks/CakePHPshould now pass with PHP 8.3.