Skip to content

Conversation

@dwightwatson
Copy link

Brief Summary of Changes

I upgraded my project to PHP 8.5 and started seeing deprecation warnings for the (boolean) cast:

  Non-canonical cast (boolean) is deprecated, use the (bool) cast instead

  at vendor/cloudinary/transformation-builder-sdk/src/Transformation/Qualifier/QualifiersAction.php:255
    251▕         $variables = ArrayUtils::get($options, 'variables', []);
    252▕ 
    253▕         $varQualifiers = [];
    254▕         foreach ($options as $key => $value) {
  ➜ 255▕             if (Variable::isVariable($key)) {
    256▕                 $varQualifiers[] = Variable::set($key, Expression::expression($value));
    257▕             }
    258▕         }
    259▕ 

This PR simply updates the (boolean) casts to (bool) which should be backwards compatible. It also updates the workflow to test against PHP 8.5.

What does this PR address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are tests included?

  • Yes
  • No

Reviewer, please note:

N/A

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant