chore(deps): update terraform cloudposse/cloudwatch-logs/aws to v0.6.9#83
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): update terraform cloudposse/cloudwatch-logs/aws to v0.6.9#83renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
|
/terratest |
89f9f40 to
cf7fc8e
Compare
7437f8d to
8586944
Compare
8586944 to
43faf90
Compare
43faf90 to
0a185fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.6.6→0.6.9Release Notes
cloudposse/terraform-aws-cloudwatch-logs (cloudposse/cloudwatch-logs/aws)
v0.6.9Compare Source
🐛 Bug Fixes
allow underscores in names @cornfeedhobo (#66)
what
why
references
🤖 Automatic Updates
Migrate new test account @osterman (#63)
what
.github/settings.yml.github/chatops.ymlfileswhy
.github/settings.ymlfrom org level to getterratestenvironmenttestaccountReferences
Update .github/settings.yml @osterman (#62)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update release workflow to allow pull-requests: write @osterman (#61)
what
.github/workflows/release.yaml) to have permission to comment on PRwhy
Update GitHub Workflows to use shared workflows from '.github' repo @osterman (#60)
what
.github/workflows) to use shared workflows from.githubrepowhy
Update GitHub Workflows to Fix ReviewDog TFLint Action @osterman (#59)
what
.github/workflows) to addissue: writepermission needed by ReviewDogtflintactionwhy
Update GitHub workflows @osterman (#58)
what
.github/workflows/settings.yaml)why
Use GitHub Action Workflows from `cloudposse/.github` Repo @osterman (#57)
what
why
cldouposse/.githubrepositoryAdd GitHub Settings @osterman (#56)
what
.github/settings.yaml)why
Update README.md and docs @cloudpossebot (#53)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
Update Scaffolding @osterman (#54)
what
make readmeto rebuildREADME.mdfromREADME.yamlwhy
.githubrepoUpdate README.md and docs @cloudpossebot (#51)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
v0.6.8Compare Source
🚀 Enhancements
Fix mistake in policy. Part2 @ramses999 (#39)
what
This is just a continuation of the fix #38.
Prod environment tested. That's how it works correctly.
v0.6.7Compare Source
🚀 Enhancements
Fix mistake in policy @ramses999 (#38)
what
Fix mistake in policy
why
The policy is created simply by ARN without the ":" construct, which is necessary to create the correct policy for the role.
Without this ":" construct, the policy is created, but it does not work correctly.
This error was discovered when I tried to create a cloudwatch group in the cloudtrail module.
I got the response "Error: Error updating CloudTrail: InvalidCloudWatchLogsLogGroupArnException: Access denied. Verify in IAM that the role has adequate permissions."
After studying the code, I realized that I need to add the construction ":*" in a couple of lines.
My solution looks like this, I need to replace the lines in file :
This line:
join("", aws_cloudwatch_log_group.default..arn),
replaced by
"${join("", aws_cloudwatch_log_group.default..arn)}:*"
You need to do this in both identical lines.
Perhaps you can suggest a better solution, I'm new to terraforming.
references
#37
https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/master/iam.tf#L55
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.