Skip to content

fix: download command in the saml context#283

Merged
cloudsmith-iduffy merged 1 commit intomasterfrom
iduffy/saml-auth-for-downloads
Mar 31, 2026
Merged

fix: download command in the saml context#283
cloudsmith-iduffy merged 1 commit intomasterfrom
iduffy/saml-auth-for-downloads

Conversation

@cloudsmith-iduffy
Copy link
Copy Markdown
Contributor

Description

Download command failed when using a SAML auth context, this change fixes that.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (please describe)

Additional Notes

@cloudsmith-iduffy cloudsmith-iduffy requested a review from a team as a code owner March 31, 2026 12:51
Copilot AI review requested due to automatic review settings March 31, 2026 12:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes cloudsmith download failures when running under a SAML/SSO auth context by ensuring /basic/ download endpoints are authenticated correctly.

Changes:

  • Convert existing Authorization: Bearer … credentials into requests Basic Auth for /basic/ download URLs.
  • Remove the prior warning path that required users to supply an API key for private /basic/ downloads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudsmith-iduffy cloudsmith-iduffy merged commit ab00984 into master Mar 31, 2026
44 checks passed
@cloudsmith-iduffy cloudsmith-iduffy deleted the iduffy/saml-auth-for-downloads branch March 31, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants