-
Notifications
You must be signed in to change notification settings - Fork 12
Feat/web 308 improve search on documentation website related tasks #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
niallobrien
wants to merge
25
commits into
main
Choose a base branch
from
feat/web-308-improve-search-on-documentation-website-related-tasks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5737b57
feat: initial commit of Algolia search integration
niallobrien ec5ff45
fix: enhance search functionality and improve search result handling
niallobrien c6c199c
fix: improve state management in Sidenav component
niallobrien ee0863d
fix: enhance search functionality by deduplicating merged search hits…
niallobrien b112b0d
fix: enhance QuickNav component with hash scrolling and improve searc…
niallobrien 92eaa66
fix: enhance search functionality with improved decoding and anchor t…
niallobrien f18f80a
fix: enhance search functionality by improving page display title and…
niallobrien a02adb5
fix: refactor QuickNav component to use selector for content area and…
niallobrien 2a2c9aa
fix: enhance search functionality with improved page display title ha…
niallobrien 9c2d948
fix: add website breadcrumb segment to search results and enhance des…
niallobrien bd9a9ff
fix: enhance search results display by adding HTTP method tags
niallobrien 3e21235
fix: improve alignment and centering for tag and search result method…
niallobrien 611780a
fix: updated search feature with added types, and homepage adjustment…
niallobrien d35875d
fix: enhance search dialog and trigger with theme support
niallobrien f074812
fix: enhance Navbar layout and improve search dialog styling
niallobrien 8ed6219
feat: add Footer component with styling and integrate into layout
niallobrien 275a8a8
feat: enhance SearchDialog and SearchTrigger with compact variant sup…
niallobrien 3a30c81
feat: improve Navbar and SearchDialog components with enhanced stylin…
niallobrien fc6f10d
feat: improve Navbar and Sidenav components with improved styling
niallobrien b144ad6
feat: enhance SearchDialog component with keyboard shortcut support a…
niallobrien fe793d6
fix: improve Navbar and Footer components with improved layout & mobi…
niallobrien 3a1d00a
fix: improves types for Hero component buttons and resolves build issue
niallobrien bd2173d
fix: updates navbar height for tablet screens and cleans up homepage …
niallobrien 409bf63
fix: update search test to check for undefined content property
niallobrien 12d61c1
fix: remove development-only Algolia API key from environment configu…
niallobrien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,4 +28,6 @@ npm-debug.log* | |
| *.tsbuildinfo | ||
| next-env.d.ts | ||
|
|
||
| docs/graph.html | ||
| docs/graph.html | ||
|
|
||
| .history | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A public Algolia API key is committed in this tracked
.envfile (and it’s aNEXT_PUBLIC_*value, so it will be exposed to the browser). Even if restricted, committing keys in-repo increases the risk of accidental reuse/privilege expansion and makes rotation harder. Remove the key from version control (e.g., move to developer-local env files and provide a.env.examplewith placeholders) and rotate the exposed key.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dev-only key. Will remove to be safe I guess.