Fix of some minor bugs when using the driver manifest and update helm chart versions#4
Open
elivlo wants to merge 3 commits intocloudstack:mainfrom
Open
Fix of some minor bugs when using the driver manifest and update helm chart versions#4elivlo wants to merge 3 commits intocloudstack:mainfrom
elivlo wants to merge 3 commits intocloudstack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of some minor bugs when using the driver manifest or helm chart. This should also create a new helm release 3.0.1 with the current app version 3.0.0.
Description of changes:
manifest.ymlwas missing a line break between two resourcesnode.metadataSourcedescription as a feasible option (csi will take the name of the kubernetes node)Testing performed:
I have set up a cluster in a private Cloudstack instance with Talos. This cluster works with the current version (3.0.0) of the csi plugin. I made some config overrides in the helm chart values by adjusting them manually. These overrides were done with terraform and can be reproduced:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.