fix(deer-go): prevent server initialization panic when APMPLUS_APP_KEY is not set#110
Open
Zerofisher wants to merge 1 commit intocloudwego:mainfrom
Open
fix(deer-go): prevent server initialization panic when APMPLUS_APP_KEY is not set#110Zerofisher wants to merge 1 commit intocloudwego:mainfrom
Zerofisher wants to merge 1 commit intocloudwego:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a server initialization panic that occurs when the APMPLUS_APP_KEY environment variable is not set. The fix prevents the server from attempting to use tracing middleware when the tracer configuration is incomplete.
- Modified server initialization logic to conditionally apply tracing middleware only when both tracer and config are available
- Added fallback server initialization without tracing when configuration is missing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: A bug fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
Fixes #109
(optional) The PR that updates user documentation: