opt(adk): return error from AddSessionValue instead of silent failure #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
runner.Run() 之后才会init session之前 session 不存在时静默返回无法得知写入失败难以调试。比如 TestWriteTodos 这个测试原来静默失败后函数继续执行返回字符串,测试只验证了返回值格式没验证 todos 是否真的写入了session
Get方法也是可能可以类似 adk-go 如果没有key也会return error 他们Set err都是nil大概率接口保留
https://github.com/google/adk-go/blob/main/session/database/session.go
改动
break了api但是感觉return err更合理一些