Account for output file names in task ids - #11
Merged
Conversation
![cls-python-workflows[bot]](https://avatars.githubusercontent.com/u/115809360?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark cosy-luigi
Details
| Benchmark suite | Current: 233b8e2 | Previous: 22deab7 | Ratio |
|---|---|---|---|
benchmarks/test_benchmark_chain_100.py::test_benchmark_chain_creation |
0.7974994225689546 iter/sec (stddev: 0.013172075254131058) |
0.6345847411186485 iter/sec (stddev: 0.013068131550962335) |
0.80 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 312 390 +78
Branches 21 23 +2
=========================================
+ Hits 312 390 +78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
task_idof aCoSyLuigiTasknow accounts for the filenames of the targes specified in theoutputmethod.This allows:
Register, which comes with a variable speedup across the boardAdditionally, this PR adds the appropriate tests, including one that highlights what the issue initially was, referred to as "Shading" in this context (terminology up to debate).