Remove benchmark MockTargets - #7
Merged
Merged
Conversation
![cls-python-workflows[bot]](https://avatars.githubusercontent.com/u/115809360?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark cosy-luigi
Details
| Benchmark suite | Current: bf3b72c | Previous: 5aa1f57 | Ratio |
|---|---|---|---|
benchmarks/test_benchmark_chain_100.py::test_benchmark_chain_creation |
0.7988236959369961 iter/sec (stddev: 0.005828576513415856) |
0.676701866714135 iter/sec (stddev: 0.008257711944939388) |
0.85 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 315 312 -3
Branches 21 21
=========================================
- Hits 315 312 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jekannadar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't run any pipelines in the benchmark, but just check how fast CoSy-Luigi can create their structure, the MockTargets for
complete()are not needed.