Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#300
Merged
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#300
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the test environment to support PHPUnit 8.5, which is needed for PHP 7.2 compatibility. The project currently supports PHP 7.1-8.5, and this change fills a gap in PHPUnit version support: PHPUnit 7.5 is used for PHP < 7.3, PHPUnit 8.5 for PHP 7.2-8.0, and PHPUnit 9.6 for PHP 7.3+. Additionally, the PR simplifies the CI workflow and improves Docker command reliability.
Changes:
- Add PHPUnit 8.5 to the version constraint in composer.json to support PHP 7.2 with a more modern PHPUnit version
- Simplify PHPUnit test execution in CI workflow by consolidating two conditional commands into one with inline conditionals
- Improve Docker workflow reliability by using named image tags instead of querying for the last built image
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Adds PHPUnit 8.5 to the version constraint to bridge the gap between PHPUnit 7.5 and 9.6 for PHP 7.2 support |
| .github/workflows/ci.yml | Consolidates duplicate PHPUnit commands into a single command with conditional logic, and adds explicit Docker image tags for better reliability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5. This is needed to run the tests on legacy platforms due to recent upstream changes as discussed in clue/reactphp-redis#180.
Builds on top of clue/reactphp-redis#180 and #221 and others