Upgrade language level to PHP 7.4 - #20
Open
jkrzefski wants to merge 1 commit into
Open
Conversation
jkrzefski
force-pushed
the
feature/php-7.4
branch
from
October 1, 2020 20:48
734518b to
aadcaf5
Compare
…ndencies and make PHPUnit tests compatible
jkrzefski
force-pushed
the
feature/php-7.4
branch
from
October 1, 2020 20:55
aadcaf5 to
4831c43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I increased the minimum required version of PHP to 7.4 and added strong type hints everywhere I could. It was not always possible, but I think it turned out pretty good. I updated all composer dependencies and I also added PHPUnit and PHP-CS-Fixer as development dependencies. I also had to fix the unit tests to be compatible with PHPUnit 9.
The tests all run successfully now, but I would appreciate a second opinion on whether they still make sense.