Skip to content

Improve PHP 8.5+ support and update test environment#50

Merged
clue merged 1 commit intoclue:1.xfrom
clue-labs:php8.5
Feb 28, 2026
Merged

Improve PHP 8.5+ support and update test environment#50
clue merged 1 commit intoclue:1.xfrom
clue-labs:php8.5

Conversation

@clue
Copy link
Owner

@clue clue commented Feb 28, 2026

@clue clue added this to the v1.4.0 milestone Feb 28, 2026
@clue clue added the new feature New feature or request label Feb 28, 2026
@clue clue requested a review from Copilot February 28, 2026 23:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependencies and CI to better accommodate newer PHP versions (PHP 8.5+) while tightening SSE retry parsing behavior and adjusting tests for newer PHP reflection behavior.

Changes:

  • Extend CI matrix to include PHP 8.5 and update the checkout action version.
  • Tighten retry: field parsing rules in MessageEvent::parse() and expand coverage for edge cases.
  • Adjust reflection usage in tests to avoid PHP 8.1+ setAccessible() behavior changes.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/MessageEvent.php Updates validation logic for parsing retry: values.
tests/MessageEventTest.php Adds more invalid retry: cases to the data provider.
tests/EventSourceTest.php Conditionally avoids ReflectionProperty::setAccessible() for PHP 8.1+.
composer.json Updates ReactPHP dependency constraints.
.github/workflows/ci.yml Adds PHP 8.5 to CI matrix and updates actions/checkout major version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clue clue merged commit 445e314 into clue:1.x Feb 28, 2026
18 checks passed
@clue clue deleted the php8.5 branch February 28, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants