Improve PHP 8.5+ support and update test environment#50
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependencies and CI to better accommodate newer PHP versions (PHP 8.5+) while tightening SSE retry parsing behavior and adjusting tests for newer PHP reflection behavior.
Changes:
- Extend CI matrix to include PHP 8.5 and update the checkout action version.
- Tighten
retry:field parsing rules inMessageEvent::parse()and expand coverage for edge cases. - Adjust reflection usage in tests to avoid PHP 8.1+
setAccessible()behavior changes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/MessageEvent.php |
Updates validation logic for parsing retry: values. |
tests/MessageEventTest.php |
Adds more invalid retry: cases to the data provider. |
tests/EventSourceTest.php |
Conditionally avoids ReflectionProperty::setAccessible() for PHP 8.1+. |
composer.json |
Updates ReactPHP dependency constraints. |
.github/workflows/ci.yml |
Adds PHP 8.5 to CI matrix and updates actions/checkout major version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #47, #49, #26, reactphp/promise#264, reactphp/event-loop#282, and clue/framework-x#297