`cargo build --features num-bigint` fails to build

[sylvestre]

with trunk:

   Compiling num-modular v0.6.1 (/home/sylvestre/dev/debian/num-modular)
error[E0432]: unresolved import `num_integer`
 --> src/bigint.rs:3:5
  |
3 | use num_integer::Integer;
  |     ^^^^^^^^^^^ use of undeclared crate or module `num_integer`

error[E0432]: unresolved import `num_traits`
 --> src/bigint.rs:4:5
  |
4 | use num_traits::{One, ToPrimitive, Zero};
  |     ^^^^^^^^^^ use of undeclared crate or module `num_traits`

error[E0432]: unresolved import `num_traits`
   --> src/bigint.rs:109:9
    |
109 |     use num_traits::Signed;
    |         ^^^^^^^^^^ use of undeclared crate or module `num_traits`

error[E0599]: no method named `to_usize` found for reference `&BigUint` in the current scope
   --> src/bigint.rs:131:33
    |
131 |             if let Some(sm) = m.to_usize() {
    |                                 ^^^^^^^^
    |
    = help: items from traits can only be used if the trait is in scope
help: trait `ToPrimitive` which provides `to_usize` is implemented but not in scope; perhaps you want to import it
    |
107 +     use num_traits::cast::ToPrimitive;
    |

[cmpute]

I can't reproduce your issue locally, could you share you system, rust version and the,command you used?

[sylvestre]

Sure

$ rustc --version
rustc 1.78.0 (9b00956e5 2024-04-29)

On a Debian testing

$ git clone git@github.com:cmpute/num-modular.git 
$ cd num-modular       
$ cargo build --features num-bigint

[simonbuchan]

At minimum, num-bigint feature should declare num-integer and num-traits as dependencies, so a workaround is to also add those.

You might not be seeing it locally because something else is enabling those features?

[xtqqczze]

@cmpute I just checked using Rust 1.95 and the crate still fails to build with the num-bigint feature.

[cmpute]

@xtqqczze I have fixed the issue. Please check if the crate builds successfully with your configuration again. (I haven't published a new version)

[cmpute]

Again, please try the latest version. The fix has been published along with other improvements.

[xtqqczze]

I’ve finally managed to get it working in uutils/num-prime#127. The complicating factor was that num-modular v0.6.2 introduced a breaking change by removing the num-integer feature in a patch release, so cargo update wasn’t sufficient to update the dependency.