Sneaky Hijack Edgecase#12480
Open
Drulikar wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR does several things:
/datum/hive_status/proc/bless_on_hijack(); and hijack round status+ stat tracking into/datum/controller/subsystem/hijack/proc/on_call_shuttle())Technically a xeno evolving as queen on the Almayer could still be in this scenario, but I think it even less likely to occur and unlikely for them to succeed enough that warrants needing to put the game into a hijack state.
Explain why it's good for the game
Presently admins have been sort of having to intervene whenever a queen sneaks onto the dropship, but since hijack effects are kinda all over the place its difficult for them to do all changes nor in a way that really thematically can work. Now its as if the dropship has its autopilot disabled shortly before docking procedures and ends up crashing into the ship (because the queen is a bad driver).
Testing Photographs and Procedure
Screenshots & Videos
Normal hijack + transmute testing: https://youtu.be/CuSb9vs2NiQ
Stealth hijack as marine: https://youtu.be/mL4UUED1mqA
Stealth hijack as xeno: https://youtu.be/u05M-Y6q32E
Changelog
🆑 Drathek
balance: A hostile queen that sneaks on a shuttle will now trigger a hijack automatically just before arrival
fix: Fixed grant transmute on hijack buff loop stopping early if it encounters a king or xeno with the ability already
fix: Hive buff purchase for transmute no longer is applied to queen
/:cl: