Repository navigation
fix: regenerate members.json after the catalog ExternalDNS fix - #2015
Merged
Merged
Conversation
The catalog normalisation that listed ExternalDNS once on /architectures did not regenerate data/members.json, so /members still spelled the project External-dns for SNCF: the project filter offered two options for one project, selecting ExternalDNS omitted SNCF, and the SNCF profile disagreed with /architectures/sncf-onprem. Regenerate the artifact and add a test that reconciles each member's projects and industries with the catalog entries behind its architectures, so a catalog edit that skips regeneration fails the required check instead of shipping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2014
Remit:
/memberslists ExternalDNS twice in the project filter, filtering byExternalDNSomits SNCF, and the SNCF profile shows a project name that contradicts/architectures/sncf-onprem.What changes
data/members.json: regenerated withnpm run generate:members(one content change: SNCFExternal-dns->ExternalDNS).tests/members-data.test.mjs: new test reconciling each member'sprojectsandindustrieswith the catalog entries behind itsarchitectures. Against the stale file it fails withsncf projects drifted from data/architectures/catalog.json; run npm run generate:members; it passes after regeneration.Note on the issue's draft test
The draft keyed catalog entries by
entry.slug, butgenerate-members.mjsgroups them byorgToSlug(entry.organization), so that join matches nothing and the test would pass vacuously. This version joins throughmember.architectures[].id, which the artifact already carries, and asserts every listed architecture resolves to a catalog entry.Verification
node --test tests/members-data.test.mjs tests/generate-members.test.mjs: 56 pass