-
Notifications
You must be signed in to change notification settings - Fork 24
[quality] /assign's failure arms are never driven through dist/index.js #301
Copy link
Copy link
Open
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmedHive verified that an open PR references or claims this issue; still actionable until confirmedhive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Description
Activity
Metadata
Metadata
Assignees
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmedHive verified that an open PR references or claims this issue; still actionable until confirmedhive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Finding
src/issueComment/assign.tsis fully unit-covered but the bundle e2e suite only drives its two happy paths (bundle.test.ts: self-assign by an org member; argument users with the stranger dropped). Its failure arms never run against the shipped bundle:could not self assign: the self-assignPOST /issues/1/assigneesis refusedno authorized users found: every argument user fails the org-member / collaborator / has-commented readscould not add assignees: the argument-userPOST /issues/1/assigneesis refusedTwo further uncovered lines are not reachable through
dist/index.jsand are left out of scope: line 29 (payload without an issue number — not anissue_commentshape) and line 61 (could not get authorized users—checkOrgMember/checkCollaborator/checkIssueCommentseach catch their own API errors and returnfalse, sogetOrgCollabCommentUserscannot throw over HTTP).Evidence
npx vitest run --coverageonmain@ 3fc21f2 →assign.ts100 % lines (suite: 100 / 99.81 / 100 / 100).npm run test:coverage:e2eonmain@ 3fc21f2 →assign.ts81.48 % lines, uncovered29,42,61,66,79.Recommendation
__tests__/bundle/assignArms.test.tsdriving the three reachable arms throughdist/index.jsagainst the fake GitHub: refused self-assign write, no authorized argument users (no write issued), refused argument-user write — asserting exit 1, the::error::text, and the exact request sequenceMeasured with that file:
assign.tse2e 81.48 % → 92.59 % lines (only 29 and 61 remain).Cluster:
src/issueComment/assign.tsfailure arms, bundle e2e. Disjoint from the held bundle PRs (#242 cron jobs input, #244 /meow, #246 label commands, #283 OWNERS auth, #286 approve.github_review, #289 merge gate labels, #291 blunderbuss, #293 hold/sweep, #296 /close + /milestone, #298 owners-label, #300 fixed labels) — none drives/assign.Priority
Filed by quality agent (hold-gated mode)
🐝 Hive Agent:
quality| Instance:hosted-available-lke648397-260827-5q9t| SHA:3fc21f2— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88