-
Notifications
You must be signed in to change notification settings - Fork 24
[quality] /retest and /ok-to-test's refusal, no-op and failure arms never run through dist/index.js #303
Copy link
Copy link
Open
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmedHive verified that an open PR references or claims this issue; still actionable until confirmedhive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Description
Activity
Metadata
Metadata
Assignees
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmedHive verified that an open PR references or claims this issue; still actionable until confirmedhive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Finding
src/issueComment/trigger.ts(the/retest,/testand/ok-to-testcommands) is fully covered by the unit suite but only its happy paths are exercised end-to-end against the shipped bundle.Unit evidence —
npx vitest run --coverage __tests__/issueCommentTest/trigger.test.ts __tests__/pullReqonmain@ 3fc21f2 (Node v26.10.0, vitest 5.0.3):trigger.ts | 100 | 100 | 100 | 100.End-to-end evidence —
npm run test:coverage:e2eonmain@ 3fc21f2 (the source-mapped bundle from #274,__tests__/bundle/*.test.ts, 142 tests):trigger.ts108/132 statements, 81.67 % lines. Uncovered throughdist/index.js:/reteston an issue that is not a pull request/retestwith no failed run: the "N in progress, N successful" summary comment, with and without a summary/retestwhen everyrerun-failed-jobsanswers 409: "already being re-run"/ok-to-teston an issue that is not a pull request/ok-to-teston a pull request already carryingok-to-testwith nothing awaiting approvalapprovePendingRuns403 (namesactions: write) and any other approval failure/ok-to-testby the pull request author (refuseAuthor)listWorkflowRunsForRepofailurererunfailure that is neither 409 nor 403refusewhen the refusal comment itself cannot be postedpull_requestwithout a head sha,issue_commentwithout an issue number, a comment without an idThe existing
/retestand/ok-to-testcases in__tests__/bundle/bundle.test.ts(issue_comment trigger commands on a pull request) and the/testcases in__tests__/bundle/triggerTestAndLgtmCancel.test.tscover only the success paths plus/test's 409/403 arms. None of the open hold-gated bundle PRs (#242–#302) touchtrigger.ts.Recommendation
__tests__/bundle/triggerArms.test.tsdriving each/retestand/ok-to-testarm above throughdist/index.jsagainst the fake GitHub, asserting the exit status,::error::lines, the comment bodies and the exact request sequence after authorization (hold-gated PR open)The three payload-shape guards (188, 207, 293) are deliberately left out: they need a malformed event payload rather than a GitHub API answer, and the unit suite already pins them.
Priority
/retestwith nothing failed,/ok-to-testby the author, a token withoutactions: write)Filed by quality agent (hold-gated mode)
🐝 Hive Agent:
quality| Instance:hosted-available-lke648397-260827-5q9t| SHA:3fc21f2— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88