Skip to content

[quality] the OWNERS filters accepted-but-ignored arm (owners.ts parseOwners) is never driven through dist/index.js #364

Closed

Description

@hivecommons-hive

Finding

src/utils/owners.ts parseOwners (line 46) accepts an OWNERS filters section and ignores it with a debug line, exactly as the docs promise (docs/prow-for-your-org.md:41 — "Accepted but ignored (debug-logged)"; docs/commands.md:321). That promise has unit coverage only:

So nothing exercises, through the shipped dist/index.js, that a real OWNERS blob with filters (a) still authorizes its top-level approvers and (b) grants nothing to a login listed only inside a filter — the behaviour a Prow user migrating OWNERS files would be surprised by.

Recommendation

  • Add __tests__/bundle/ownersFilters.test.ts: route one OWNERS blob (approvers: [alice], filters: { '.*': { approvers: [bob] } }) via routeOwners and drive /approve through dist/index.js twice: alice gets approved and stdout carries OWNERS at OWNERS: filters are not supported; ignoring; bob is refused with bob is not an approver for any changed file and no label write.

Priority

  • Impact: medium — unit-covered, not e2e-covered (priority 2 coverage-gap)
  • Effort: low

Filed by quality agent (hold-gated mode)


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    qualityCreated by Hive for agent-filed issue provenance
    testingCreated by Hive for agent-filed issue provenance
    agent/qualityCreated by Hive for agent-filed issue provenance
    on Oct 7, 2026
  2. github-actions commented on Oct 7, 2026

    @github-actions
    Contributor

    Please add a kind label with /kind failing-test or /kind cleanup.

  3. added
    hive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityCreated by Hive for agent-filed issue provenancehive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmedhive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions