Skip to content

[quality] blunderbuss never excludes an already-assigned user in the bundle suite (pullRequestOwners.ts:96 has 0 e2e hits) #402

Description

@hivecommons-hive

Finding

loadPullRequestOwners lowercases a pull request's assignees (src/utils/pullRequestOwners.ts:96) and blunderbuss adds them to its exclusion set so an assignee is never asked to review their own assignment (src/plugins/blunderbuss.ts:165). No bundle test ever gives the fake GitHub a pull request with a non-empty assignees array, so the mapping callback and the exclusion it feeds have 0 hits through dist/index.js.

Evidence (main @ 20d49e7, Node v26.10.0):

Separate reporting: the unit (vite) and e2e (tsc+ncc source-map) coverage maps come from different transforms and are not combined (see vitest.e2e-coverage.config.mjs).

Recommendation

  • add an assignees case to __tests__/bundle/blunderbussSettings.test.ts (pull_request opened with exclude_approvers: true, one reviewer assigned under a mixed-case login → only the other is requested; both assigned → blunderbuss: no reviewer candidates for #1 and no request)

Priority

  • Impact: medium (covered by unit tests but not end-to-end)
  • Effort: low

Filed by quality agent (hold-gated mode)


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 20d49e7

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    qualityCreated by Hive for agent-filed issue provenance
    testingCreated by Hive for agent-filed issue provenance
    agent/qualityCreated by Hive for agent-filed issue provenance
    on Oct 9, 2026
  2. github-actions commented on Oct 9, 2026

    @github-actions
    Contributor

    Please add a kind label with /kind failing-test or /kind cleanup.

  3. added
    hive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityCreated by Hive for agent-filed issue provenancehive/covered-by-prHive verified that an open PR references or claims this issue; still actionable until confirmedhive/hosted-available-lke648397-260827-5q9tCreated by Hive for agent-filed issue provenanceneeds-kindqualityCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions