Repository navigation
chore(prow): add kind/feature label - #487
Merged
Merged
Conversation
Feature requests (cncf#485) had no valid /kind to clear needs-kind; the require_matching_label comment only offered failing-test and cleanup. Adds kind/feature with the Kubernetes color and lists it in the comment. label-sync creates it on merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
kind/featurelabel to.github/prow.yamland lists it in therequire_matching_labelmissing_comment. Feature requests such as #485 had no valid/kindto clearneeds-kind(the author tried/kind feature-requestand/kind enhancement, neither of which exists); the comment only offeredfailing-testandcleanup.label-syncruns on push tomainwhenprow.yamlchanges, so the label is created on merge.Refs #485
Testing
Config-only change; no code paths touched.
/kind featureon Add support for GitHub Groups to the Approve plugin #485 and feat(owners): support GitHub groups in OWNERS #486 after merge clearsneeds-kind(to be verified post-merge oncelabel-synchas run)Checklist
npm run allto lint and build my code — N/A, config onlynpm run packand committeddist/— N/A, nosrc/changemissing_commentupdated; no docs enumerate the repo's own kinds