Skip to content

ci(test): run the bundle e2e coverage suite in its own job - #488

Merged
mrbobbytables merged 1 commit into
cncf:mainfrom
mrbobbytables:ci/e2e-coverage-job
Oct 15, 2026
Merged

mrbobbytables merged 1 commit into
cncf:mainfrom
mrbobbytables:ci/e2e-coverage-job

Conversation

@mrbobbytables

Copy link
Copy Markdown
Member

Description

build-test in .github/workflows/test.yml runs npm run test:coverage (unit) but never npm run test:coverage:e2e, so the only measurement of what the bundle acceptance suite exercises in src/ through the compiled bundle existed solely on whoever last ran it locally. This adds an e2e-coverage job that runs alongside build-test (the suite takes several minutes on its own, so it is not appended serially), writes the same four-metric table to the job summary, and uploads coverage-e2e/ as coverage-e2e-<sha> for 14 days.

It is reporting only — not a required check — matching the intent in #459 ("a record, not a gate"). #463 already set reportsDirectory: 'coverage-e2e' in vitest.e2e-coverage.config.mjs and ignored the directory, so the job runs plain npm run test:coverage:e2e with no flag. #484 (threshold floor) can follow once this is in.

Fixes #459

Testing

  • node -e "require('js-yaml').load(fs.readFileSync('.github/workflows/test.yml'))" — parses; jobs: build-test, e2e-coverage, repack-dist, push-repacked-dist
  • npm run test:coverage:e2e on this branch (main @ d51aeb3) — passed: 78 files / 481 tests; coverage-e2e/coverage-summary.json written: statements 99.56% (2506/2517), branches 97.46% (1615/1657), functions 98.79% (491/497), lines 99.54% (2386/2397)
  • The summary node -e snippet run locally against that coverage-e2e/coverage-summary.json prints the expected markdown table
  • The job itself will first run on this PR's own CI

Checklist

  • I ran npm run all to lint and build my code — N/A, workflow only
  • I ran npm run pack and committed dist/ — N/A, no src/ change
  • Commits are signed off (DCO)
  • Note any new dependencies these changes bring in — none; reuses the already-pinned actions/checkout, actions/setup-node and actions/upload-artifact SHAs
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation — docs/contributing.md:48 already describes test:coverage:e2e; nothing enumerates CI jobs
  • My changes generates no new warnings (please describe new warnings if unavoidable)

test.yml only ran the unit coverage, so npm run test:coverage:e2e had
no CI run or artifact. Adds a parallel e2e-coverage job mirroring the
unit summary/artifact steps. Reporting only, not a required check.
cncf#463 already points the config at coverage-e2e/, so no flag is needed.

Fixes cncf#459

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
@github-actions

Copy link
Copy Markdown
Contributor

Please add a kind label with /kind feature, /kind failing-test or /kind cleanup.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
a5476f9

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @mrbobbytables, head a5476f9bc4a9) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/test.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/test.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@mrbobbytables
mrbobbytables merged commit 9300e11 into cncf:main Oct 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] test.yml never runs test:coverage:e2e — add a parallel e2e-coverage job so bundle-suite coverage has a CI run and artifact

1 participant