Repository navigation
ci(test): run the bundle e2e coverage suite in its own job - #488
Merged
Merged
Conversation
test.yml only ran the unit coverage, so npm run test:coverage:e2e had no CI run or artifact. Adds a parallel e2e-coverage job mirroring the unit summary/artifact steps. Reporting only, not a required check. cncf#463 already points the config at coverage-e2e/, so no flag is needed. Fixes cncf#459 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
2 tasks
Contributor
|
Please add a kind label with |
Contributor
a5476f9
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @mrbobbytables, head
Hive did not add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
build-testin.github/workflows/test.ymlrunsnpm run test:coverage(unit) but nevernpm run test:coverage:e2e, so the only measurement of what the bundle acceptance suite exercises insrc/through the compiled bundle existed solely on whoever last ran it locally. This adds ane2e-coveragejob that runs alongsidebuild-test(the suite takes several minutes on its own, so it is not appended serially), writes the same four-metric table to the job summary, and uploadscoverage-e2e/ascoverage-e2e-<sha>for 14 days.It is reporting only — not a required check — matching the intent in #459 ("a record, not a gate"). #463 already set
reportsDirectory: 'coverage-e2e'invitest.e2e-coverage.config.mjsand ignored the directory, so the job runs plainnpm run test:coverage:e2ewith no flag. #484 (threshold floor) can follow once this is in.Fixes #459
Testing
node -e "require('js-yaml').load(fs.readFileSync('.github/workflows/test.yml'))"— parses; jobs:build-test,e2e-coverage,repack-dist,push-repacked-distnpm run test:coverage:e2eon this branch (main @ d51aeb3) — passed: 78 files / 481 tests;coverage-e2e/coverage-summary.jsonwritten: statements 99.56% (2506/2517), branches 97.46% (1615/1657), functions 98.79% (491/497), lines 99.54% (2386/2397)node -esnippet run locally against thatcoverage-e2e/coverage-summary.jsonprints the expected markdown tableChecklist
npm run allto lint and build my code — N/A, workflow onlynpm run packand committeddist/— N/A, nosrc/changeactions/checkout,actions/setup-nodeandactions/upload-artifactSHAsdocs/contributing.md:48already describestest:coverage:e2e; nothing enumerates CI jobs