Repository navigation
test(bundle): fold the sweep memo case into sweepArms, drop the root OWNERS approver case - #491
Merged
Merged
Conversation
…OWNERS approver case - sweepSharedMemos.test.ts held one case and copies of sweepArms' forkPr/runSweep and of helpers.ts routeOwners. Move the case into sweepArms.test.ts, built from that file's forkPr/routeList/runSweep and routeOwners; every assertion is kept and it still alone reaches the tokenIdentity and baseBranchTip memo-hit arms. - authorizationPolicyArms: since cncf#486 the approver case reaches the same ownersInclude arm as the reviewer case above it, and the regression it guards (rootOwnersIncludes reading reviewers only) fails auth.test.ts 'policyAllows a root OWNERS approver'. E2E line and branch-arm sets are unchanged. Signed-off-by: Jeffrey Sica <me@jeefy.dev>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #490.
forkPr/runSweepand ofrouteOwners' tip/tree/blob routes. The case now lives in ashared memos across pull requestsblock built from sweepArms'forkPr/routeList/runSweepandrouteOwners; PR 2 adds only its ownpulls/2andpulls/2/files. All assertions are unchanged, and run alone it still reaches thetokenIdentityandbaseBranchTipmemo-hit arms (it is the only case that does).ownersIncludearm as the reviewer case above it. MakingrootOwnersIncludesread reviewers only fails__tests__/utils/auth.test.ts"policyAllows a root OWNERS approver", so the guard is kept by the unit suite.E2E coverage before and after: identical line and branch-arm sets (2423 lines, 1627 arms). Lint,
test:coverageandtest:coverage:e2epass./kind cleanup