Repository navigation
chore(coverage): raise the e2e coverage floor to 99/97/99/99 to match what main reaches - #502
Open
hivecommons-hive[bot] wants to merge 1 commit into
Open
hivecommons-hive[bot] wants to merge 1 commit into
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
… what main reaches Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
Contributor
|
Please add a kind label with |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage Configuration
Files claimed:
vitest.e2e-coverage.config.mjs(coverage.thresholds+ its comment),docs/contributing.md:50(thetest:coverage:e2erow). Held PR #500 editsvitest.config.mjsanddocs/contributing.md:48(the unit row);git merge-tree --write-tree HEAD pr-500merges the two cleanly (exit 0).#484 set the e2e floor at 99 / 95 / 98 / 99 when
mainmeasured 99.54 / 96.25 / 98.79 / 99.56 (d93ecb8). With the bundle scenarios from #467–#496 merged,main@1062ce7measures:Under the old floor a scenario could stop driving 49
src/branches or 10 functions throughdist/index.jsand the run would still pass. The new floor keeps ~16 branches / ~5 functions of budget for anncc/vitestbump that shifts source-map attribution — the same margin #484 chose. Same rule as #202, #484 and #500: a floor just under whatmainreaches.Verified on this branch (Node $(node --version)):
npm run test:coverage:e2e→ 78 files / 487 tests, exit 0 under the new thresholds--exclude '__tests__/bundle/approve*.test.ts'exits 1 withCoverage for branches (94.24%) does not meet global threshold (97%)(lines 97.4 %, statements 97.48 % also fail)npx eslint vitest.e2e-coverage.config.mjscleanRelated Issue
Refs #466 — the hive folded this coverage-reporting finding into the #466 tracker as a comment; #466's remaining boxes (the
approve.ts:228,230,415andmeow.ts:88production cleanups) are production-code removals this lane does not PR and stay open for a maintainer.Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88