Skip to content

chore(coverage): raise the e2e coverage floor to 99/97/99/99 to match what main reaches - #502

Open
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-e2e-coverage-floor
Open

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-e2e-coverage-floor

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Coverage Configuration

Files claimed: vitest.e2e-coverage.config.mjs (coverage.thresholds + its comment), docs/contributing.md:50 (the test:coverage:e2e row). Held PR #500 edits vitest.config.mjs and docs/contributing.md:48 (the unit row); git merge-tree --write-tree HEAD pr-500 merges the two cleanly (exit 0).

#484 set the e2e floor at 99 / 95 / 98 / 99 when main measured 99.54 / 96.25 / 98.79 / 99.56 (d93ecb8). With the bundle scenarios from #467–#496 merged, main@1062ce7 measures:

metric main @ 1062ce7 old floor new floor
lines 99.95 % (2424/2425) 99 99
statements 99.96 % (2545/2546) 99 99
functions 100 % (500/500) 98 99
branches 97.96 % (1633/1667) 95 97

Under the old floor a scenario could stop driving 49 src/ branches or 10 functions through dist/index.js and the run would still pass. The new floor keeps ~16 branches / ~5 functions of budget for an ncc/vitest bump that shifts source-map attribution — the same margin #484 chose. Same rule as #202, #484 and #500: a floor just under what main reaches.

Verified on this branch (Node $(node --version)):

  • npm run test:coverage:e2e → 78 files / 487 tests, exit 0 under the new thresholds
  • negative check: the same config with --exclude '__tests__/bundle/approve*.test.ts' exits 1 with Coverage for branches (94.24%) does not meet global threshold (97%) (lines 97.4 %, statements 97.48 % also fail)
  • npx eslint vitest.e2e-coverage.config.mjs clean

Related Issue

Refs #466 — the hive folded this coverage-reporting finding into the #466 tracker as a comment; #466's remaining boxes (the approve.ts:228,230,415 and meow.ts:88 production cleanups) are production-code removals this lane does not PR and stay open for a maintainer.


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

… what main reaches

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 17, 2026 12:46
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

@github-actions

Copy link
Copy Markdown
Contributor

Please add a kind label with /kind feature, /kind failing-test or /kind cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Indicates that a PR should not merge because someone has issued a /hold command. needs-kind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants