add Running and LastSched to debug=3 - #15
Draft
srosenberg wants to merge 1 commit into
Draft
Conversation
extra fields for goroutine profiles in conjunction with debug=3. To facilitate troubleshooting scheduling delays, it's instructive to include both `Running` and `LastSched`. The latter is the time since the goroutine's last transition to the running state; the former is an approximate time spent in the running state. Both fields are in `g` and thus require no computation. Since the above are in nanos, we also modify `WaitSince` to be in nanos. Previous caller, i.e., `goroutineheader` is updated to keep the minutes resolution. [1] #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In [1],
StackRecordwas extended withextra fields for goroutine profiles
in conjunction with debug=3.
To facilitate troubleshooting
scheduling delays, it's instructive
to include both
RunningandLastSched.The latter is the time since the goroutine's
last transition to the running state; the former
is an approximate time spent in the running state. Both fields are in
gand thus require no computation.Since the above are in nanos, we also modify
WaitSinceto be in nanos. Previous caller, i.e.,goroutineheaderis updated to keep the minutes resolution.[1] #12