feat(embed_text): add expected_output_dimension parameter
#1373
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate API parameter (output_dimension) from validation dimension (expected_output_dimension) for clearer semantics and better flexibility. Maintains backward compatibility with fallback to output_dimension when expected_output_dimension is not specified.
Add warning when output_dimension and expected_output_dimension are both specified with different values, explaining their respective uses in schema definition vs API request.
wxh06
changed the title
expected_output_dimension parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenAI-compatible embedding APIs reject the
dimensionsparameter despite not being standard OpenAI, causing requests to fail whenoutput_dimensionis specified.I separated
output_dimension(sent to API) fromexpected_output_dimension(used for validation and schema), allowing flexible dimension handling without forcing the API parameter.