build(deps): bump shell-quote from 1.8.3 to 1.8.4#580
Conversation
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.3 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the 'shell-quote' dependency to version 1.8.4 to fix object-token shape validation. Although Codacy identifies the PR as being up to standards, this review surfaced several high-severity security vulnerabilities within the lockfile that should be addressed before merging. Specifically, the 'fast-uri' and 'tmp' packages are affected by path traversal and security filter bypass vulnerabilities (CVE-2026-6322, CVE-2026-6321, and CVE-2026-44705). Additionally, the version bump is only reflected in the lockfile; 'package.json' remains unchanged, and there are no automated tests included to verify the fix.
About this PR
- The changes are currently limited to 'yarn.lock'. If 'shell-quote' is a direct dependency, 'package.json' should also be updated to reflect the 1.8.4 version to ensure the project's dependency definition is consistent with the installed versions.
- The PR lacks automated tests to verify that 'shell-quote' now correctly handles object-token shapes as intended by the 1.8.4 release.
3 comments outside of the diff
yarn.lock
line 2714🔴 HIGH RISK
Suggestion: High-severity security vulnerabilities (CVE-2026-6322, CVE-2026-6321) have been detected in 'fast-uri'. Flaws in authority delimiter handling and path normalization can allow for security filter bypass or path traversal. Remediation of this dependency is recommended to mitigate these risks.
line 10114🔴 HIGH RISK
Suggestion: The 'tmp' package is affected by a path traversal vulnerability (CVE-2026-44705). This can allow for directory escape if unsanitized input is used for temporary file prefixes or suffixes.
line 10119🔴 HIGH RISK
Suggestion: A version of the 'tmp' package containing a path traversal vulnerability (CVE-2026-44705) was detected. Addressing this is necessary to ensure file system integrity for operations involving temporary files.
Test suggestions
- Verify that shell-quote correctly handles and validates object-token shapes as per the 1.8.4 fix.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that shell-quote correctly handles and validates object-token shapes as per the 1.8.4 fix.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps shell-quote from 1.8.3 to 1.8.4.
Changelog
Sourced from shell-quote's changelog.
Commits
ff166e2v1.8.44378a6e[Fix]quote: validate object-token shapes22ebec0[Dev Deps] update@ljharb/eslint-config,auto-changelog,eslint, `npmig...9f3caa3[Tests] increase coverage3344a04[readme] replace runkit CI badge with shields.io check-runs badge699c511[Dev Deps] update@ljharb/eslint-configDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.