Deprecate default serde & add spl-collections#92
Merged
lorisleiva merged 3 commits intocodama-idl:mainfrom Mar 10, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 13b6869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
grod220
changed the title
spl-collectionsspl-collections
grod220
commented
Mar 9, 2026
Contributor
Author
|
Ready for review when you have a chance @lorisleiva 🙏 (cc @febo) |
lorisleiva
approved these changes
Mar 9, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks! Just a couple of documentation nits but looks good to me. Febo lmk if that's okay for you too.
lorisleiva
approved these changes
Mar 10, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Nice, thanks for the changes!
Contributor
Author
|
Merge request 🙏 |
lorisleiva
approved these changes
Mar 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Replace
kaiganReplaces it with
spl-collectionsequivalentsDeprecate serde
The previous kaigan-based serde support used plain #[derive(serde::Serialize, serde::Deserialize)] on wrapper types. This was misleading. The serde representation does not match the Borsh/Wincode wire format that these types exist to encode. In the worst case, this is a bug waiting to happen. Rather than continue support and false confidence, this PR just removes it entirely. I can't really see any practical use of serde in the context of a rust client given borsh/wincode anyway.
That said, for compatibility, the renderer still allows advanced users to opt into serde explicitly via
traitOptions/ feature flags, but serde is no longer part of the default or recommended path.