test(ui): repoint script_overview.feature off prod "mc" course - #74457
Merged
Conversation
…urse "Unit overview contents" loaded /courses/mc/units/1 to check how the unit overview's summary table names a lesson in a unit that has exactly one lesson. UI tests must not depend on production curriculum, so point it at ui-test-maze, which is also a single-lesson unit. The expected cell text becomes "1. Maze Puzzles". While repointing, correct the comment. It claimed the assertion covered Lesson#localized_title's "only one lesson, so use the unit name" override, but the unit overview renders lesson.name (SummaryProgressRow.jsx:49) and never localized_title. Against mc the difference was invisible in the asserted string: mc's lesson is named "Minecraft Hour of Code" while its unit title is "Minecraft Adventurer", so the assertion has in fact been checking the lesson's own name. Verified with a local chromedriver against test-studio.code.org: the unmodified feature passed (7 scenarios), and so does the modified one (7 scenarios, 73 steps). mc stays in UI_TEST_SCRIPTS/courses_ui_tests for now: platform/login_redirect.feature (and its Playwright port) still needs a cached unit, and two @contentful_key certificate features still use mc. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
davidsbailey
marked this pull request as ready for review
August 6, 2026 22:57
etaderhold
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Unit overview contents" scenario loaded /courses/mc/units/1 to check how the unit overview's summary table names a lesson in a unit that has exactly one lesson. UI tests must not depend on production curriculum per partitioned curriculum data proposal, so point it at ui-test-maze, which is also a single-lesson unit. The expected cell text becomes "1. Maze Puzzles".
While repointing, correct the comment. It claimed the assertion covered Lesson#localized_title's "only one lesson, so use the unit name" override, but the unit overview renders lesson.name and never localized_title:
code-dot-org/apps/src/templates/progress/SummaryProgressRow.jsx
Lines 49 to 51 in 396fa8a
Testing story