refactor(auth): rename AuthState variants, add ResumePoint enum, and guard onboarding completion#814
Merged
Merged
Conversation
…guard onboarding completion Rename AuthState variants for clarity: - Registered → Onboarding - LoggedInAwaitingUser → Authenticating - LoggedInWithUser → Ready Replace the seenAccessKey boolean on Onboarding with a ResumePoint enum (AccessKey, AccessKeyThenPurchase, PostAccessKey) so the onboarding resume point is fully determined at state-set time rather than derived from seenAccessKey + userFlags at navigation time. Simplify buildNavGraphForLaunch to a pure structural mapping from ResumePoint to nav route, removing the userFlags parameter. Add resume-point reconciliation in RealSessionController.updateUserFlags() for the case where flags arrive after the initial state is set. Fix a bug where killing the app at PostAccessKey and relaunching skipped the permissions phase entirely. A persisted completedOnboarding flag in PassphraseCredentialManager is now checked in AuthManager.login() before promoting to Ready, and set reactively when the composable completes the Onboarding → Ready transition. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename AuthState variants for clarity:
Replace the seenAccessKey boolean on Onboarding with a ResumePoint enum (AccessKey, AccessKeyThenPurchase, PostAccessKey) so the onboarding resume point is fully determined at state-set time rather than derived from seenAccessKey + userFlags at navigation time.
Simplify buildNavGraphForLaunch to a pure structural mapping from ResumePoint to nav route, removing the userFlags parameter. Add resume-point reconciliation in RealSessionController.updateUserFlags() for the case where flags arrive after the initial state is set.
Fix a bug where killing the app at PostAccessKey and relaunching skipped the permissions phase entirely. A persisted completedOnboarding flag in PassphraseCredentialManager is now checked in AuthManager.login() before promoting to Ready, and set reactively when the composable completes the Onboarding → Ready transition.