fix(direct-send): replace lossy SharedFlow resolve event with StateFlow state#830
Merged
Conversation
…ow state The resolve result was emitted via a SharedFlow (replay=0), which could be missed if the amount entry screen had not subscribed yet -- causing a spurious contact not on Flipcash error. Move resolve status into a ResolveState sealed interface on the ViewModel state (StateFlow, always replays current value). The amount screen now reads resolve state reactively and handles Pending/Failed/Resolved cases proactively. Also embeds the DeviceContact in ResolveState to eliminate a separate event-based collector, and extracts a fallback display name into a string resource. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resolve result was emitted via a SharedFlow (replay=0), which could be missed if the amount entry screen had not subscribed yet -- causing a spurious contact not on Flipcash error. Move resolve status into a ResolveState sealed interface on the ViewModel state (StateFlow, always replays current value). The amount screen now reads resolve state reactively and handles Pending/Failed/Resolved cases proactively.
Also embeds the DeviceContact in ResolveState to eliminate a separate event-based collector, and extracts a fallback display name into a string resource.